Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add move to top and bottom context menu options #5151

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

kevgrig
Copy link
Contributor

@kevgrig kevgrig commented Jan 23, 2024

Changes

After adding an item to a playlist, I often want to move it to the top and it's tedious to drag and drop if the playlist is large. This adds 'Move to Top' and 'Move to Bottom' options to a playlist item context menu.

Issues

None

@kevgrig kevgrig requested a review from a team as a code owner January 23, 2024 03:15

This comment was marked as outdated.

@dmitrylyzo dmitrylyzo added the feature New feature or request label Jan 23, 2024
Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

@kevgrig

This comment was marked as duplicate.

@kevgrig
Copy link
Contributor Author

kevgrig commented May 13, 2024

Screenshot_20240512_215815

Copy link
Member

@1hitsong 1hitsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing in Waterfox in Windows 11

Display of options works as expected.

Clicking on Move to Top / Move to Bottom results in an error and items in playlist aren't moved.
image

src/components/shortcuts.js Outdated Show resolved Hide resolved
@thornbill thornbill added this to the v10.10.0 milestone Jun 9, 2024
@kevgrig kevgrig requested a review from 1hitsong June 24, 2024 23:08
After adding an item to a playlist, I often want to move it to
the top and it's tedious to drag and drop if the playlist is large.
This adds 'Move to Top' and 'Move to Bottom' options to a playlist
item context menu.
Signed-off-by: Kevin G <kevin@myplaceonline.com>
Copy link

sonarcloud bot commented Aug 22, 2024

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit 40074c643356afa50c93794fcd32a85766fdc70e
Status ✅ Deployed!
Preview URL https://98410afc.jellyfin-web.pages.dev
Type 🔀 Preview

Copy link
Member

@thornbill thornbill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The context menu is getting way too complex, but fixing that will require more substantial changes. This works as expected in my testing and I don't want to block it since the menu is already a mess. 🙃

@thornbill thornbill merged commit a649b12 into jellyfin:master Aug 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants