Add setting to prioritise what audio codec to transcode to #5434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrylyzo
reviewed
Apr 30, 2024
dmitrylyzo
reviewed
Apr 30, 2024
gnattu
reviewed
May 1, 2024
src/strings/en-us.json
Outdated
| @@ -553,6 +553,7 @@ | |||
| "LabelAudioCodec": "Audio codec", | |||
| "LabelAudioLanguagePreference": "Preferred audio language", | |||
| "LabelSelectAudioNormalization": "Audio Normalization", | |||
| "LabelSelectPreferredTranscodeAudioCodec": "Preferred transcode audio codec", | |||
There was a problem hiding this comment.
Please be explicit that this only affects Audio track in Videos. Because the Audio transcoding will use a very different server-side logic.
There was a problem hiding this comment.
What if we add a header?
<div class="verticalSection verticalSection-extrabottompadding">
<h2 class="sectionTitle">
${HeaderVideoAdvanced}
</h2>
<!-- select goes here -->
<div>Not sure about wording.
There was a problem hiding this comment.
If we are not rushing this with 10.9 release, then we can do a re-organize of the transcoding panel to make it easier to follow. It currently has a lot of options inside and a lot of options are actually very hard to find.
There was a problem hiding this comment.
Yes, ideally there should be a dedicated view to customize the device profile.
The problem with the 10.9 release is that we can't add translations to the release branch - Weblate can only push to the master branch, iirc.
gnattu
reviewed
May 1, 2024
gnattu
reviewed
May 1, 2024
dmitrylyzo
approved these changes
May 4, 2024
This comment has been minimized.
This comment has been minimized.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dmitrylyzo
reviewed
May 5, 2024
Co-authored-by: Dmitry Lyzo <56478732+dmitrylyzo@users.noreply.github.com>
|
Cloudflare Pages deployment
|
ConnorS1110
pushed a commit
to ConnorS1110/jellyfin-web
that referenced
this pull request
Jun 5, 2024
…5434) * Add setting to prioritise what audio codec to transcode to * Add comment * rename selectPreferredTranscodeAudio to preferredTranscodeAudio * Add review changes * Add review changes * Add reviewed fixes * Add help text. * Fix elint Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Change *AudioCodecInVideo to *VideoAudioCodec and move option to video advanced * Update src/components/playbackSettings/playbackSettings.template.html Co-authored-by: Dmitry Lyzo <56478732+dmitrylyzo@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dmitry Lyzo <56478732+dmitrylyzo@users.noreply.github.com>
ConnorS1110
pushed a commit
to ConnorS1110/jellyfin-web
that referenced
this pull request
Jun 9, 2024
…5434) * Add setting to prioritise what audio codec to transcode to * Add comment * rename selectPreferredTranscodeAudio to preferredTranscodeAudio * Add review changes * Add review changes * Add reviewed fixes * Add help text. * Fix elint Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Change *AudioCodecInVideo to *VideoAudioCodec and move option to video advanced * Update src/components/playbackSettings/playbackSettings.template.html Co-authored-by: Dmitry Lyzo <56478732+dmitrylyzo@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dmitry Lyzo <56478732+dmitrylyzo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a setting to prioritise what audio codec to transcode to.
Changes
Issues
Helps resolve jellyfin/jellyfin-tizen#204