Fix background being invisible with theme videos #5640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this should be rebased on the |
mihawk90
force-pushed
the
theme-videos-fix
branch
from
7b75abb
to
d68794d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
Sorry my bad, I didn't think of targeting the release branch. Welp, something went wrong with that rebase 🤣 |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Ah there we go, I should have updated the base before pushing I guess... Seems CI choked on it :/ |
dmitrylyzo
added
bug
dmitrylyzo
approved these changes
Jun 3, 2024
thornbill
force-pushed
the
theme-videos-fix
branch
from
d68794d
to
ba36747
Compare
|
(rebased to trigger CI) |
|
joshuaboniface
pushed a commit
that referenced
this pull request
Jun 5, 2024
Fix background being invisible with theme videos Original-merge: 7854c4b Merged-by: thornbill <thornbill@users.noreply.github.com> Backported-by: Joshua M. Boniface <joshua@boniface.me>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I noticed that since I updated to 10.9 the skin's background would disappear when a theme video was playing and therefore some text would be unreadable depending on the video in the background.
Before:
After:
This basically restores pre-10.9 behaviour.
Issues
Couldn't find any open issues for this.
Calling in @grhallenbeck since the cause was introduced in ce4c7ae / #5076 and there might have been a reason I'm not seeing.
The
videoPlayerContainerandbackgroundContainerelements are the first 2 elements in the DOM structure though. They are already at the lowest layer of elements, makingz-indexseem redundant here. The issue is that thevideoPlayerContainerspecifies noz-indexat all so the-1made thebackgroundContainerbe rendered behind the video (or culled entirely, not sure how the actual rendering pipeline works :P ).