Fixed being unable to properly long press on cards to multiselect on Firefox #5660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thornbill here is my fixed PR |
|
nielsvanvelzen
approved these changes
Jun 5, 2024
thornbill
added
bug
joshuaboniface
pushed a commit
that referenced
this pull request
Jun 5, 2024
Fixed being unable to properly long press on cards to multiselect on Firefox Original-merge: 5680c18 Merged-by: thornbill <thornbill@users.noreply.github.com> Backported-by: Joshua M. Boniface <joshua@boniface.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In
showSelectedwe were not adding thecheckedInitialclass for Firefox when selecting an element. This did not allow for proper selection of the cards. There was a comment that claimed this was because Firefox did not handle click events the same as other browsers, but it seems this was either not true, or was maybe misunderstood. I simply removed the condition and it has restored proper multiselect functionality on Firefox.Issues
None that I know of, but this has been bothering me for many months now