-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add non-standard multi-value audio tag support #5869
Conversation
Cloudflare Pages deployment
|
7e74044
to
524ede4
Compare
src/components/libraryoptionseditor/libraryoptionseditor.template.html
Outdated
Show resolved
Hide resolved
src/components/libraryoptionseditor/libraryoptionseditor.template.html
Outdated
Show resolved
Hide resolved
src/components/libraryoptionseditor/libraryoptionseditor.template.html
Outdated
Show resolved
Hide resolved
src/components/libraryoptionseditor/libraryoptionseditor.template.html
Outdated
Show resolved
Hide resolved
src/components/libraryoptionseditor/libraryoptionseditor.template.html
Outdated
Show resolved
Hide resolved
src/components/libraryoptionseditor/libraryoptionseditor.template.html
Outdated
Show resolved
Hide resolved
src/components/libraryoptionseditor/libraryoptionseditor.template.html
Outdated
Show resolved
Hide resolved
Co-authored-by: Dmitry Lyzo <56478732+dmitrylyzo@users.noreply.github.com>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a UI perspective, everything is fine.
As for the server side, here performers
are split by /
. Maybe we should use custom delimiters there as well? Or not split at all (force users to use multiple Artist
tags)?
Current behaviour:
mediaInfo.Artists: ["K/DA", "Madison Beer, (G)I-DLE, Lexie Liu, League of Legends, Jaira Burns, Seraphine"]
track.Artist: "K\u001fDA, Madison Beer, (G)I-DLE, Lexie Liu, League of Legends, Jaira Burns, Seraphine"
performers: ["K", "DA, Madison Beer, (G)I-DLE, Lexie Liu, League of Legends, Jaira Burns, Seraphine"]
It is so interesting that you can manually have I created files with |
Not sure where it came from. I have |
Then it could be something magic happening for ASCII/Windows encoding to UTF-8 conversion. Because the internal separator is not intended for external use and I explicitly picked a control character in UTF-8 so that it is very very unlikely to be inserted by our users. The conversion thing is only my guess though, I don't know how the 2F becomes 1F exactly. |
If my guessing is correct, you change |
Changes
This adds the Audio Tag settings GUI to library settings for Music.
Issues
Depends on jellyfin/jellyfin#12385