Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix branch name passed to CF Pages for forks #5892

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

thornbill
Copy link
Member

Changes
We were only passing the branch name for forks (not repo/branch) and the CF action does not like that

Issues
https://github.com/jellyfin/jellyfin-web/actions/runs/10289023129/job/28475913635?pr=5880

@thornbill thornbill added github-actions Pull requests that update Github Actions code ci This PR or issue mainly concerns CI labels Aug 7, 2024
@thornbill thornbill added this to the v10.10.0 milestone Aug 7, 2024
@thornbill thornbill requested a review from a team as a code owner August 7, 2024 18:33
Copy link

sonarcloud bot commented Aug 7, 2024

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit 40b7aeddc24b263d6b6f8bb28ab92b2cd6dbf142
Status ❌ Failure. Check workflow logs for details
Preview URL Not available
Type 🔀 Preview

@thornbill thornbill merged commit 1a9f51c into jellyfin:master Aug 7, 2024
11 of 12 checks passed
@thornbill thornbill deleted the fix-cf-pages-branch-2 branch August 7, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci This PR or issue mainly concerns CI github-actions Pull requests that update Github Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants