Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to stylistic eslint rules #5935

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

thornbill
Copy link
Member

Changes
Code style rules are deprecated in eslint and removed in the next major version. Moving to the stylistic plugin should unblock some of the pending eslint updates.

  • Migrate to stylistic plugin eslint rules
  • Fix auto-fixable errors

Issues
N/A

@thornbill thornbill added the build This PR or issue mainly concerns build tools label Aug 21, 2024
@thornbill thornbill added this to the v10.10.0 milestone Aug 21, 2024
@thornbill thornbill requested a review from a team as a code owner August 21, 2024 07:04
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint doesn't pass. Please fix all ESLint issues.

src/index.d.ts Show resolved Hide resolved
Copy link

sonarcloud bot commented Aug 21, 2024

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit 8a6f33fff898f6f887b429b4f471aa2305dda54d
Status ✅ Deployed!
Preview URL https://9d352279.jellyfin-web.pages.dev
Type 🔀 Preview

Copy link
Contributor

@dmitrylyzo dmitrylyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not sure about the bot suggestion - ESLint doesn't give any errors locally.

@thornbill
Copy link
Member Author

The bot comments for warnings and errors. These are just warnings. 🙂

@thornbill thornbill merged commit afd2801 into jellyfin:master Aug 21, 2024
12 checks passed
@thornbill thornbill deleted the eslint-stylistic branch August 21, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build This PR or issue mainly concerns build tools
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants