Fix hidden scheduled task progress updates causing errors #5966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thornbill
requested changes
Aug 27, 2024
p0358
force-pushed
the
patch-hidden-tasks-error
branch
from
c92f64c
to
edbf596
Compare
|
idk if doing a force-push instead of second commit didn't break github there |
Cloudflare Pages deployment
|
thornbill
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
An
IConfigurableScheduledTaskcan be defined withIsHidden => true, which as expected causes it to not be drawn in the UI, nor are its elements created. However, task progress updates would still arrive and cause an error in code that assumed the elements would exist.Issues
N/A, but merging jellyfin/jellyfin#12511 has a chance of exposing this bug if someone opens admin panel on scheduled tasks page quickly enough after server startup (overall a rather minor bug probably as such)