Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to material react table #5970

Merged
merged 7 commits into from
Aug 30, 2024

Conversation

thornbill
Copy link
Member

@thornbill thornbill commented Aug 26, 2024

Changes

  • Replaces the @mui/x-data-grid library with material-react-table. This library is still based on mui (and tanstack table), but without any paywalled features (unlike the current library).
  • Fixes some issues with the useLogEntries and useUsers hooks
  • Updates components and hooks to use new project structure

In a future PR we could improve the filters over the default text based filtering. (The datetime filtering requires some additional work to ensure our current locale is available in the React context.)

Issues
N/A

@thornbill thornbill added enhancement Improve existing functionality or small fixes dependencies Pull requests that update a dependency file labels Aug 26, 2024
@jellyfin-bot jellyfin-bot added the merge conflict Conflicts prevent merging label Aug 27, 2024
@jellyfin-bot

This comment was marked as outdated.

@jellyfin-bot jellyfin-bot removed the merge conflict Conflicts prevent merging label Aug 27, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint doesn't pass. Please fix all ESLint issues.

src/apps/dashboard/routes/activity.tsx Outdated Show resolved Hide resolved
src/apps/dashboard/routes/activity.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint doesn't pass. Please fix all ESLint issues.

src/apps/dashboard/routes/activity.tsx Outdated Show resolved Hide resolved
@thornbill thornbill marked this pull request as ready for review August 27, 2024 16:46
@thornbill thornbill requested a review from a team as a code owner August 27, 2024 16:46
@thornbill thornbill added this to the v10.10.0 milestone Aug 27, 2024
Copy link
Contributor

@dmitrylyzo dmitrylyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work, in general.
There are checkboxes to hide columns, but for some reason they don't work.

Copy link

sonarcloud bot commented Aug 29, 2024

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit ff18bedca7b75416a8dfdea6906eddd3ccceb316
Status ✅ Deployed!
Preview URL https://ef7f2ae6.jellyfin-web.pages.dev
Type 🔀 Preview

@thornbill thornbill merged commit 7c32707 into jellyfin:master Aug 30, 2024
12 checks passed
@thornbill thornbill deleted the material-react-table branch August 30, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement Improve existing functionality or small fixes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants