Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply Maximum Allowed Audio Channels to DirectPlay #5972

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Apply Maximum Allowed Audio Channels to DirectPlay #5972

merged 1 commit into from
Aug 27, 2024

Conversation

dmitrylyzo
Copy link
Contributor

Changes
Apply Maximum Allowed Audio Channels to DirectPlay. Only if explicitly selected.

Issues
Fixes #5715

@dmitrylyzo dmitrylyzo added enhancement Improve existing functionality or small fixes stable backport Backport into the next stable release playback This PR or issue mainly concerns playback labels Aug 27, 2024
@dmitrylyzo dmitrylyzo requested a review from a team as a code owner August 27, 2024 10:31
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@dmitrylyzo dmitrylyzo added this to the v10.9.10 milestone Aug 27, 2024
@thornbill thornbill modified the milestones: v10.9.10, v10.9.11 Aug 27, 2024
thornbill
thornbill approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@thornbill thornbill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm I doubt this will backport cleanly though 😅

@thornbill thornbill merged commit 20ea604 into jellyfin:release-10.9.z Aug 27, 2024
9 checks passed
@dmitrylyzo dmitrylyzo deleted the max-audio-channels branch August 28, 2024 07:51
joshuaboniface pushed a commit that referenced this pull request Sep 7, 2024
@dmitrylyzo @joshuaboniface
Backport pull request #5972 from jellyfin-web/release-10.9.z
5e33b98 
Apply Maximum Allowed Audio Channels to DirectPlay

Original-merge: 20ea604

Merged-by: thornbill <thornbill@users.noreply.github.com>

Backported-by: Joshua M. Boniface <joshua@boniface.me>
@jellyfin-bot jellyfin-bot removed the stable backport Backport into the next stable release label Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

Assignees
No one assigned
Labels
enhancement Improve existing functionality or small fixes playback This PR or issue mainly concerns playback
Projects
No open projects
Release 10.9.z
Status: Done
Milestone
v10.9.11
Development

Successfully merging this pull request may close these issues.
3 participants
@dmitrylyzo @thornbill @jellyfin-bot