Add audio options to workaround compatability problems #5986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felix920506
reviewed
Aug 29, 2024
There was a problem hiding this comment.
I think it would be better to have the "force remux flac" option on by default for chromium and Firefox, as these browsers are known to have problems with flac metadata. This would ensure maximum compatibility for most users.
We can then tell users to disable it if they are that allergic to remuxing.
|
I still think something like this should be the last resort and not a default setting unless this issue is very widespread, but IMO it is not the case yet. |
thornbill
reviewed
Sep 4, 2024
thornbill
added
feature
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
gnattu
force-pushed
the
add-audio-compatability-options
branch
from
bde199f
to
f6efaaf
Compare
|
Cloudflare Pages deployment
|
dmitrylyzo
approved these changes
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This adds some audio compatibility options to workaround certain issues:
Issues
Fixes jellyfin/jellyfin#3731 (incompatible metadata)
Fixes jellyfin/jellyfin#11113 (inaccurate timestamp)