Allow editing of original title for Season and Episode items #5990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
thornbill
requested changes
Sep 3, 2024
| @@ -541,7 +541,7 @@ function setFieldVisibilities(context, item) { | |||
| hideElement('#fldPath', context); | |||
| } | |||
|
|
|||
| if (item.Type === 'Series' || item.Type === 'Movie' || item.Type === 'Trailer' || item.Type === 'Person') { | |||
| if (item.Type === 'Series' || item.Type === 'Season' || item.Type === 'Episode' || item.Type === 'Movie' || item.Type === 'Trailer' || item.Type === 'Person') { | |||
There was a problem hiding this comment.
We should do something like:
if ([ 'Series', 'Season', 'Episode', ... ].includes(item.Type)) {Bonus points if you also use the BaseItemKind enum values instead of hardcoded strings. 😉
thornbill
reviewed
Sep 20, 2024
| @@ -21,7 +21,7 @@ import ServerConnections from '../ServerConnections'; | |||
| import toast from '../toast/toast'; | |||
| import { appRouter } from '../router/appRouter'; | |||
| import template from './metadataEditor.template.html'; | |||
| import { SeriesStatus } from '@jellyfin/sdk/lib/generated-client'; | |||
| import { BaseItemKind, SeriesStatus } from '@jellyfin/sdk/lib/generated-client'; | |||
There was a problem hiding this comment.
To ensure tree-shaking can happen during the build, we should use the full path for these imports @jellyfin/sdk/lib/generated-client/models/base-item-kind (I think).
|
Cloudflare Pages deployment
|
thornbill
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Allows editing of original title for Season and Episode items.
Issues