Fix @tanstack/query-devtools on legacy browsers #5997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thornbill
reviewed
Sep 3, 2024
src/RootApp.tsx
Outdated
| @@ -18,7 +18,9 @@ const RootApp = () => ( | |||
| </WebConfigProvider> | |||
| </UserSettingsProvider> | |||
| </ApiProvider> | |||
| <ReactQueryDevtools initialIsOpen={false} /> | |||
| {window.Proxy && ( // '@tanstack/query-devtools' requires 'Proxy', which cannot be polyfilled for legacy browsers | |||
There was a problem hiding this comment.
Should we also check browser.tv?
There was a problem hiding this comment.
To hide it on TVs?
There was a problem hiding this comment.
Yes since it makes navigation weird... although I have been thinking about adding a custom menu entry or something for it because I hate the floating button 😅
dmitrylyzo
force-pushed
the
fix-legacy-devtools
branch
from
e0dd76f
to
0fbfda8
Compare
|
Cloudflare Pages deployment
|
thornbill
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
@tanstack/query-devtoolsto Babel.ReactQueryDevtoolson unsupported devices.Issues
N/A
developmentbuild doesn't work on legacy devices.Remarks
We probably don't need it on TVs though - weird navigation.