Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add detail view buttons #6039

Merged
merged 5 commits into from
Sep 28, 2024
Merged

Add detail view buttons #6039

merged 5 commits into from
Sep 28, 2024

Conversation

grafixeyehero
Copy link
Member

Changes

  • Add detail view buttons
  • Add global Api hooks

@grafixeyehero grafixeyehero requested a review from a team as a code owner September 8, 2024 16:57
github-actions[bot]
github-actions bot requested changes Sep 8, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint doesn't pass. Please fix all ESLint issues.

src/apps/experimental/features/details/components/buttons/MoreCommandsButton.tsx Show resolved Hide resolved
github-actions[bot]
github-actions bot previously requested changes Sep 8, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint doesn't pass. Please fix all ESLint issues.

src/apps/experimental/features/details/components/buttons/MoreCommandsButton.tsx Outdated Show resolved Hide resolved
src/apps/experimental/features/details/hooks/api/useGetItemByType.ts Outdated Show resolved Hide resolved
@grafixeyehero @dmitrylyzo
apply suggestion
49b0ba3 
Co-authored-by: dmitrylyzo <56478732+dmitrylyzo@users.noreply.github.com>
dmitrylyzo
dmitrylyzo reviewed Sep 9, 2024
View reviewed changes
src/strings/en-us.json Outdated Show resolved Hide resolved
@grafixeyehero @dmitrylyzo
apply suggestion
1c18fa8 
Co-authored-by: dmitrylyzo <56478732+dmitrylyzo@users.noreply.github.com>
thornbill
thornbill requested changes Sep 20, 2024
View reviewed changes
src/strings/en-us.json Outdated Show resolved Hide resolved
src/strings/en-us.json Outdated Show resolved Hide resolved
src/strings/en-us.json Outdated Show resolved Hide resolved
src/apps/experimental/features/details/hooks/api/useGetItemByType.ts Outdated Show resolved Hide resolved
@grafixeyehero grafixeyehero added the typescript PRs or issues relating to TypeScript code label Sep 21, 2024
@thornbill
Copy link
Member

@grafixeyehero now that I am looking at this not on mobile wouldn't throw and return Promise.reject behave the same way for async functions? 😅

@grafixeyehero
Copy link
Member Author

grafixeyehero commented Sep 23, 2024 •
edited
Loading

@grafixeyehero now that I am looking at this not on mobile wouldn't throw and return Promise.reject behave the same way for async functions? 😅

Yes, they behave the same.

@grafixeyehero @thornbill
apply suggestion
c5bbd5b 
Co-authored-by: Bill Thornton <thornbill@users.noreply.github.com>
@thornbill
Copy link
Member

Sorry I think we should just revert that last change. I have seen issues with live reloading when running the webpack dev server where queries seem to run when they shouldn't be enabled, but after thinking about it more, if that becomes a recurring issue we should investigate a proper fix at that time instead of just silencing the error.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit c5bbd5bca9fbf54e6bb035fa7c85b0b1b01ac159
Status ✅ Deployed!
Preview URL https://8e20d65f.jellyfin-web.pages.dev
Type 🔀 Preview

@thornbill thornbill merged commit f405602 into jellyfin:master Sep 28, 2024
12 checks passed
@thornbill thornbill added this to the v10.10.0 milestone Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitrylyzo dmitrylyzo dmitrylyzo left review comments

@thornbill thornbill thornbill approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
typescript PRs or issues relating to TypeScript code
Projects
Jellyfin 10.10
Status: Done
Milestone
v10.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@grafixeyehero @thornbill @jellyfin-bot @dmitrylyzo