Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editing device info when there are no options yet #6148

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

nielsvanvelzen
Copy link
Member

We changed the API to only return device options when they exist, otherwise 404. Previously it would always return something.

Changes

  • Catch errors for the GetDeviceOptions operation
  • Rename variables to be a bit more descriptive

Issues

Fixes jellyfin/jellyfin#12762

@nielsvanvelzen nielsvanvelzen requested a review from a team as a code owner October 1, 2024 16:52
Copy link

sonarcloud bot commented Oct 1, 2024

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit 7fe4c5c63fb58d83934dd9f10c7bcba083aa4d39
Status ✅ Deployed!
Preview URL https://05e7b328.jellyfin-web.pages.dev
Type 🔀 Preview

@thornbill thornbill added the bug Something isn't working label Oct 8, 2024
@thornbill thornbill added this to the v10.10.0 milestone Oct 8, 2024
@thornbill thornbill merged commit 3a6aaf2 into jellyfin:master Oct 8, 2024
12 checks passed
@nielsvanvelzen nielsvanvelzen deleted the fix-no-device-options branch October 9, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

GetDeviceOptions operation returns 404 for valid device id
3 participants