Fix LiveTV Playback

[viown]

Fixes LiveTV playback not working when specifying mediaSourceId

Changes

Issues
Fixes #6164

[viown]

@dmitrylyzo Also is mediaSourceId not working with live TV a server bug? (returns NoCompatibleStream). Would it be better to fix this on the server than workaround it here?

[dmitrylyzo]

@dmitrylyzo Also is mediaSourceId not working with live TV a server bug? (returns NoCompatibleStream). Would it be better to fix this on the server than workaround it here?

Probably. Here and here MediaSourceId is superseded by LiveStreamId. Here it is not.
I don't know why we need 2 separate parameters or even why we can't use the item id as the source for LiveTV.

Possible fix: we can make them mutually exclusive:

jellyfin-web/src/components/playback/playbackmanager.js

Lines 459 to 464 in 3a33ed9

	if (mediaSourceId) {
	query.MediaSourceId = mediaSourceId;
	}
	if (liveStreamId) {
	query.LiveStreamId = liveStreamId;
	}

    if (liveStreamId) {
        query.LiveStreamId = liveStreamId;
    } else if (mediaSourceId) {
        query.MediaSourceId = mediaSourceId;
    }

There was a regression in the server that was recently fixed. Made a comment on that issue. But now I think that it fails here. I am surfing the code from mobile and could be wrong.

[viown]

I should note that liveStreamId isn't set by getPlaybackMediaSource

jellyfin-web/src/components/playback/playbackmanager.js

Line 2867 in 3a33ed9

return getPlaybackInfo(player, apiClient, item, deviceProfile, mediaSourceId, null, options).then(function (playbackInfoResult) {

[joshjryan]

I tested Live TV with these changes on the 10/7/24 10.10 build, and live TV works with these changes.
I did not do additional testing with DefaultAudioStreamIndex or DefaultSubtitleStreamIndex.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[jellyfin-bot]

Cloudflare Pages deployment

Latest commit	07316cf870948483bd740a147b222282d2ab4818
Status	✅ Deployed!
Preview URL	https://99ffe07a.jellyfin-web.pages.dev
Type	🔀 Preview