Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix padding issues in the metadata manager #6187

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Fix padding issues in the metadata manager #6187

merged 1 commit into from
Oct 10, 2024

Conversation

thornbill
Copy link
Member

Changes

  • Fixes some padding issues in the metadata manager... it's not perfect, but much better imo
Before

Screenshot 2024-10-10 at 11-01-08 Metadata Manager
After

Screenshot 2024-10-10 at 11-00-00 Metadata Manager

Issues
N/A

@thornbill thornbill added the enhancement Improve existing functionality or small fixes label Oct 10, 2024
@thornbill thornbill requested a review from a team as a code owner October 10, 2024 15:03
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit 2235d162e7a418e6a1747ae1e2588cd55f51b4cb
Status ✅ Deployed!
Preview URL https://1ee322c3.jellyfin-web.pages.dev
Type 🔀 Preview

nielsvanvelzen
nielsvanvelzen approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks like 💩 but slightly better

@thornbill thornbill added this to the v10.10.0 milestone Oct 10, 2024
@thornbill thornbill merged commit f81e404 into jellyfin:master Oct 10, 2024
12 checks passed
@thornbill thornbill deleted the metadata-manager-padding branch October 10, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsvanvelzen nielsvanvelzen nielsvanvelzen approved these changes

Assignees
No one assigned
Labels
enhancement Improve existing functionality or small fixes
Projects
Jellyfin 10.10
Status: Done
Milestone
v10.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@thornbill @jellyfin-bot @nielsvanvelzen