-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show Skip Button When 'Next Video Info Overlay' is Disabled #6258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloudflare Pages deployment
|
jumoog
approved these changes
Oct 26, 2024
thornbill
added
enhancement
Improve existing functionality or small fixes
stable backport
Backport into the next stable release
labels
Oct 28, 2024
thornbill
reviewed
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I only had a minor suggestion to keep formatting consistent.
Co-authored-by: Bill Thornton <thornbill@users.noreply.github.com>
Co-authored-by: Bill Thornton <thornbill@users.noreply.github.com>
Quality Gate passedIssues Measures |
thornbill
approved these changes
Oct 30, 2024
joshuaboniface
pushed a commit
that referenced
this pull request
Nov 3, 2024
Show Skip Button When 'Next Video Info Overlay' is Disabled Original-merge: 3311a14 Merged-by: thornbill <thornbill@users.noreply.github.com> Backported-by: Joshua M. Boniface <joshua@boniface.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts the behavior of the skip button based on the 'Next Video Info Overlay' setting. When the overlay option is enabled, the up-next info box is displayed as expected. However, if the setting is disabled, the regular segment skip button will be shown instead, allowing for a more consistent experience based on user preference.