Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #868 - Add fallback if win32api.FindExecutable cannot find git #1215

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Issue #868 - Add fallback if win32api.FindExecutable cannot find git #1215

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de03bd7
Add fallback if win32api.FindExecutable cannot find git (Issue #868)
Sep 20, 2023
d196e59
Add fallback if win32api.FindExecutable cannot find git (Issue #868)
Sep 20, 2023
8fcf558
Merge branch 'master' of https://github.com/mbellgardt/dulwich
Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions dulwich/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1330,11 +1330,15 @@ def find_git_command() -> List[str]:
if sys.platform == "win32": # support .exe, .bat and .cmd
try: # to avoid overhead
import win32api
import pywintypes
except ImportError: # run through cmd.exe with some overhead
return ["cmd", "/c", "git"]
else:
status, git = win32api.FindExecutable("git")
return [git]
try:
status, git = win32api.FindExecutable("git")
return [git]
except pywintypes.error:
return ["cmd", "/c", "git"]
else:
return ["git"]

Expand Down
Loading