Use webkit API 4.1 where available or 4.0 if not. #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I think we can drop the 4.0 dependency soon since at least all new Ubuntu versions provide the 4.1 variant. |
This is viable as yourself/upstream has newer requirements than any distro build. I can always work with changes and is no major issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes in this pull request
Use webkit API 4.1 where available or 4.0 if not.
Closes issues: #713
Note: Not a change I like to make as multiple runtime deps across builds creates more testing for me. However, rednotebook is small enough as a project that additional time needed is minimal.