Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(trusted): controller VM #337

Merged
merged 4 commits into from
May 2, 2023
Merged

feat(trusted): controller VM #337

merged 4 commits into from
May 2, 2023

Conversation

smerle33
Copy link
Collaborator

as per jenkins-infra/helpdesk#3486
following #333 and #334

adding a controller VM

@smerle33 smerle33 requested review from a team, dduportal and lemeurherve April 28, 2023 13:33
lemeurherve
lemeurherve previously approved these changes Apr 28, 2023
View reviewed changes
dduportal
dduportal reviewed Apr 28, 2023
View reviewed changes
trusted.ci.jenkins.io.tf Outdated Show resolved Hide resolved
dduportal
dduportal reviewed Apr 28, 2023
View reviewed changes
trusted.ci.jenkins.io.tf Outdated Show resolved Hide resolved
dduportal
dduportal reviewed Apr 28, 2023
View reviewed changes
trusted.ci.jenkins.io.tf Outdated Show resolved Hide resolved
dduportal
dduportal requested changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, only blockers are the SSDs. The rest of the PR code looks really good at first glance!

@smerle33 smerle33 requested a review from dduportal April 28, 2023 14:52
@dduportal dduportal self-assigned this May 2, 2023
dduportal
dduportal reviewed May 2, 2023
View reviewed changes
trusted.ci.jenkins.io.tf Outdated Show resolved Hide resolved
dduportal
dduportal reviewed May 2, 2023
View reviewed changes
trusted.ci.jenkins.io.tf Outdated Show resolved Hide resolved
dduportal
dduportal previously approved these changes May 2, 2023
View reviewed changes
@dduportal dduportal removed their assignment May 2, 2023
@smerle33 smerle33 requested a review from dduportal May 2, 2023 13:12
@smerle33 smerle33 enabled auto-merge (squash) May 2, 2023 13:50
dduportal
dduportal approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@smerle33 smerle33 merged commit 011e04d into jenkins-infra:main May 2, 2023
smerle33 added a commit that referenced this pull request May 2, 2023
@smerle33
Revert "feat(trusted): controller VM (#337)"
f836624 
This reverts commit 011e04d.
@smerle33 smerle33 mentioned this pull request May 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja left review comments

@dduportal dduportal dduportal approved these changes

@lemeurherve lemeurherve lemeurherve left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@smerle33 @dduportal @timja @lemeurherve @smerleCB