Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(publick8s,privatek8s) define infraciadmin SA with a terraform module #448

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

dduportal
Copy link
Contributor

Ref. jenkins-infra/helpdesk#3679

Same as jenkins-infra/digitalocean#134 + jenkins-infra/digitalocean#136 but for Azure

Please note that the privatek8s SA can be used directly by the pod of jenkins-infra/kubernetes-management by mounting the token in the pod directly.

…m module

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal
Copy link
Contributor Author

Plan: 6 to add, 0 to change, 0 to destroy.

with the first inital plan.

I'm gonna import the existing resources, report here and run again the plan, before setting the PR as ready for review

@dduportal
Copy link
Contributor Author

Report after imports

  • publick8s
    • SA already existing: imported, should not change
    • ClusterRoleBinding existing: imported, should not change
    • Token already existing but with another name: imported but should be recreated (breaking effectively the builds of kubernetes-management until the kubeconfig is changed both manually and as code in sops
  • privatek8s nothing existing: gotta be created by this PR once merged

@dduportal dduportal marked this pull request as ready for review August 9, 2023 11:09
@dduportal dduportal requested a review from a team August 9, 2023 11:09
@dduportal dduportal merged commit 01cfa3c into jenkins-infra:main Aug 9, 2023
1 check passed
@dduportal dduportal deleted the helpdesk-3679 branch August 9, 2023 11:15
@dduportal
Copy link
Contributor Author

  • Build number 655 removed the imported resources before this PR was merged:
    • Before, I was expecting 4 resources to create + 1 to delete (3 creates for private, 1 re-create for public)
    • After, 6 resource to be created from scratch
    • Note: it breaks kube management until credentials are updated
  • Build number 657 created the 6 resources successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants