chore(privatek8s) ignore changes for upgrade_settings to avoid never-ending updated attribute
#732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ending updated attribute Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
changed the title
upgrade_settings to avoid never-ending updated attribute
dduportal
commented
Jun 18, 2024
dduportal
deleted the
chore/aks/spot-nodepools/ignore-chane-upgrade-settings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #727 , #730 and #731
This fixes the never-ending changed attribute
upgrade_settings {}for the 2 Spot node pools onprivatek8s.It follows the tip found in hashicorp/terraform-provider-azurerm#24020 (comment) to avoid having all of our plans trying to change the 2 node pools.