Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(releaseci): adding a dedicated disk/pv/pvc for release.ci as standard-zrs #768

Merged
merged 5 commits into from
Jul 3, 2024

Conversation

smerle33
Copy link
Collaborator

@smerle33 smerle33 commented Jul 2, 2024

as per jenkins-infra/helpdesk#4044

preparing the migration from premium to standard ZRS

@smerle33 smerle33 marked this pull request as ready for review July 2, 2024 08:25
@smerle33 smerle33 requested review from a team and dduportal July 2, 2024 08:25
locals.tf Outdated Show resolved Hide resolved
@smerle33 smerle33 requested a review from dduportal July 2, 2024 09:08
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass of review:

  • Overall work looks good 👍
  • Blockers (see suggestions) due to copy and paste

privatek8s.tf Outdated Show resolved Hide resolved
release.ci.jenkins.io.tf Outdated Show resolved Hide resolved
release.ci.jenkins.io.tf Outdated Show resolved Hide resolved
release.ci.jenkins.io.tf Outdated Show resolved Hide resolved
release.ci.jenkins.io.tf Outdated Show resolved Hide resolved
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
@smerle33
Copy link
Collaborator Author

smerle33 commented Jul 2, 2024

First pass of review:

* Overall work looks good 👍

* Blockers (see suggestions) due to copy and paste

can't believed I missed it

Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plan: 7 to add, 0 to change, 0 to destroy.

LGTM

Please wait for the end of the weekly release 2.465 (today) before merging this PR

@smerle33 smerle33 merged commit 5ea4a2f into jenkins-infra:main Jul 3, 2024
3 checks passed
@smerle33 smerle33 deleted the releaseci/standard-zrs branch July 3, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants