Make architecture independent #36
Conversation
Dockerfile
Outdated
| && echo "deb [arch=amd64] https://packages.microsoft.com/repos/azure-cli/ $(lsb_release -cs) main" | tee /etc/apt/sources.list.d/azure-cli.list \ | ||
| && apt-get update \ | ||
| && apt-get install --yes --no-install-recommends azure-cli="${AZURE_CLI_VERSION}-1~$(lsb_release -cs)" \ | ||
| && az --version \ | ||
| && az --version || echo 'this will currently fail on non amd64 architectures' \ |
There was a problem hiding this comment.
You might be interested in https://github.com/jenkins-infra/packer-images/blob/main/provisioning/ubuntu-provision.sh#L223-L235 : this is how we install az for the VM templates, which has arm64 ubuntu support (but 20.04)
There was a problem hiding this comment.
Thanks, I've tested and it works on 22.04 as well
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
…ava` binary - jenkins-infra/docker-packaging#36 removed JDK8 and changed the `JAVA_HOME` value - #237 and #232 changed the Docker image but we forgot to update the pod config
|
The switch to Java 11 at the same time as upgrading the base distribution 4 years' worth of releases was more than a bit aggressive, and this causes Javadoc generation errors in the release. These can be reproduced locally against a clean checkout by running The Javadoc failure is caused by missing generated sources, and these sources are generated by |
|
thanks, see jenkins-infra/release#242 |
|
Failed with:
|
|
Could reproduce locally, changing it to |
works locally but not part of stage:release apparently -.- |
Note 1: this removes java 8 from the packaging image
Note 2: this isn't fully arch independent as the Azure CLI doesn't publish an arm package, but it's not needed for the packaging part so contributors can test just fine, I've made it not fail the build now
I've tested this locally and I can build packages just fine
I expect it to work just fine for releasing, we have a weekly this upcoming week we could test it on before LTS release.
Its important this image works on arm64 as any contributors on recent laptops won't be able to test packaging changes without it