Linter using Github Actions #8

SarveshLimaye · 2021-11-04T04:48:05Z

Added super-linter using github actions

Create linter.yml

dduportal

Hello @SarveshLimaye thanks for this PR.

The current workflow succeeded, but did not executed any lint on the helm charts provided in the repository. Usually, the tool ct (https://github.com/helm/chart-testing) is used for linting helm charts
Whatever tool is used, could you add a documentation to explain for a contributor how they could execute the same linting on their own machine when contributing? The idea is that we should not wait for a PR with the GitHub workflow execution to be able to lint.

SarveshLimaye · 2021-11-04T10:51:46Z

@dduportal Thanks for the feedback. :)
The documentation for linting has to be added in readme right? Can I attach the link to the official doc of the super-linter? It is explained in detail there.

lemeurherve · 2021-11-04T11:15:28Z

* The current workflow succeeded, but did not executed any lint on the helm charts provided in the repository. Usually, the tool `ct` ([helm/chart-testing](https://github.com/helm/chart-testing)) is used for linting helm charts

Official GHA: https://github.com/helm/chart-testing-action

SarveshLimaye · 2021-11-04T11:22:23Z

* The current workflow succeeded, but did not executed any lint on the helm charts provided in the repository. Usually, the tool `ct` ([helm/chart-testing](https://github.com/helm/chart-testing)) is used for linting helm charts

Official GHA: https://github.com/helm/chart-testing-action

@lemeurherve Thanks for this . It should be exactly same as the example workflow in official gha right ?

lemeurherve · 2021-11-04T11:25:22Z

It should be quite similar, ot sure if it should be exactly the same.

SarveshLimaye · 2021-11-05T15:50:03Z

@lemeurherve @dduportal is it fine now ? I am sorry by mistakenly I opened a new pull request. I have closed it now.

dduportal · 2021-11-05T17:54:34Z

Hello @SarveshLimaye , thanks for your work! The check linter is failing with the following error message:

Run changed=$(ct list-changed)
  changed=$(ct list-changed)
  if [[ -n "$changed" ]]; then
    echo "::set-output name=changed::true"
  fi
  shell: /usr/bin/bash -e {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.7.12/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.7.12/x64/lib
    CT_CONFIG_DIR: /opt/hostedtoolcache/ct/v3.4.0/x86_64/etc
    VIRTUAL_ENV: /opt/hostedtoolcache/ct/v3.4.0/x86_64/venv
Error: Error running process: exit status 128
Error: Process completed with exit code 1.

I'm not sure why to be honest... We'll take time to review next week, but if you know what to do with this error, please proceed

SarveshLimaye · 2021-11-25T11:07:32Z

Hello, I am not sure about the error. Can you pls review the changes.

lemeurherve · 2021-12-08T12:48:09Z

@SarveshLimaye sorry for the late response, I think the problem comes from here: helm/chart-testing#330
I'll add a suggestion to try fixing it.

.github/workflows/lint-test.yml

lemeurherve · 2021-12-08T12:53:48Z

Tried to remove the shallow cloning, it didn't worked...

lemeurherve · 2021-12-08T12:54:34Z

Related issue: helm/chart-testing-action#69

lemeurherve

This should fix the check, I've made a PR in the action repository too: helm/chart-testing-action#75

lemeurherve · 2021-12-08T13:04:59Z

.github/workflows/lint-test.yml

+      - name: Run chart-testing (list-changed)
+        id: list-changed
+        run: |
+          changed=$(ct list-changed)


Suggested change

changed=$(ct list-changed)

changed=$(ct list-changed --target-branch main)

SarveshLimaye · 2021-12-08T15:50:59Z

This should fix the check, I've made a PR in the action repository too: helm/chart-testing-action#75

@lemeurherve Thank you so much for the fix . Is it fine now ?

SarveshLimaye · 2021-12-08T15:55:51Z

Don't know why the test is still failing.

dduportal · 2021-12-22T11:09:16Z

Hi @SarveshLimaye ! Many thanks for your patience and efforts to make this happen!

I'm trying to reproduce the issue loclly but I got a bad feeling about ct.
I don't really understand why the "latest" release is 2.5.0 (on both the GitHub repository and homebrew on my macOS workstation), while the github action uses the 3.4.0.

Currently, the github actions reports the following error when running the command ct lint (with ct v3.4.0):

Linting charts...
------------------------------------------------------------------------------------------------------------------------
Error: Error linting charts: Error identifying charts to process: Error running process: exit status 128
No chart changes detected.
------------------------------------------------------------------------------------------------------------------------
Error linting charts: Error identifying charts to process: Error running process: exit status 128

If I try to reproduce on my current local setup (ct 2.5.0) I also got an error:

ct lint
Linting charts...
Error loading configuration: 'chart_schema.yaml' neither specified nor found in default locations

=> I assume that we should target 3.4.0. The goal for you and I is to reproduce the error locally before going forward.
=> Another task for you: do not forget to rebase your PR against the latest version:

Add a git remote named upstream on your working directory, that point to the upstream (e.g. git remote add upstream https://github.com/jenkins-infra/helm-charts/, then check with git remote -v that the setup is ok. Once OK, or if already done, retrieve the latest changes with git fetch --all --prune)
** Then run the git rebase upstream/main command, followed by git push origin main --force if the rebase was successful.
** OR if you prefer merging, you can git merge upstream/main and git push origin main

dduportal · 2021-12-22T11:12:18Z

@SarveshLimaye Another tip: https://github.com/helm/chart-testing/blob/main/doc/ct_lint.md#synopsis .
The command ct lint only check for changed charts (which is an empty list by default). You need more flags to ensure that it does lint all the available charts.

SarveshLimaye · 2021-12-22T15:57:42Z

Hey @dduportal Thanks for the review and tips. Will try to reproduce the error locally for 3.4.0.

dduportal · 2022-08-04T13:15:40Z

Hello 👋

As the jenkins-infra team is trying to move as much workload to Jenkins controller as possible, we are closing this issue.

SarveshLimaye added 2 commits November 4, 2021 10:14

Create linter.yml

a4371d4

Merge pull request #1 from SarveshLimaye/linter

0cf0c3e

Create linter.yml

dduportal requested changes Nov 4, 2021

View reviewed changes

SarveshLimaye added 3 commits November 5, 2021 21:04

Merge branch 'jenkins-infra:main' into main

adedff2

Merge branch 'jenkins-infra:main' into main

5e5d791

updtaed linter.yaml

5305506

Merge branch 'jenkins-infra:main' into main

825ad02

lemeurherve requested changes Dec 8, 2021

View reviewed changes

.github/workflows/lint-test.yml Show resolved Hide resolved

Update .github/workflows/lint-test.yml

3d579ac

lemeurherve requested changes Dec 8, 2021

View reviewed changes

.github/workflows/lint-test.yml Show resolved Hide resolved

Update .github/workflows/lint-test.yml

23840c7

lemeurherve requested changes Dec 8, 2021

View reviewed changes

SarveshLimaye added 2 commits December 8, 2021 21:11

Merge branch 'jenkins-infra:main' into main

b6d6d63

Update lint-test.yml

e98decf

Merge branch 'jenkins-infra:main' into main

ffb6c53

SarveshLimaye and others added 2 commits December 30, 2021 14:58

Merge branch 'jenkins-infra:main' into main

fb92233

Merge branch 'main' into main

58114fb

dduportal closed this Aug 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Linter using Github Actions #8

Linter using Github Actions #8

SarveshLimaye commented Nov 4, 2021

dduportal left a comment

SarveshLimaye commented Nov 4, 2021

lemeurherve commented Nov 4, 2021

SarveshLimaye commented Nov 4, 2021

lemeurherve commented Nov 4, 2021 •

edited

Loading

SarveshLimaye commented Nov 5, 2021

dduportal commented Nov 5, 2021

SarveshLimaye commented Nov 25, 2021

lemeurherve commented Dec 8, 2021

lemeurherve commented Dec 8, 2021

lemeurherve commented Dec 8, 2021

lemeurherve left a comment

lemeurherve Dec 8, 2021

SarveshLimaye commented Dec 8, 2021 •

edited

Loading

SarveshLimaye commented Dec 8, 2021 •

edited

Loading

dduportal commented Dec 22, 2021

dduportal commented Dec 22, 2021

SarveshLimaye commented Dec 22, 2021

dduportal commented Aug 4, 2022

	changed=$(ct list-changed)
	changed=$(ct list-changed --target-branch main)

Linter using Github Actions #8

Linter using Github Actions #8

Conversation

SarveshLimaye commented Nov 4, 2021

dduportal left a comment

Choose a reason for hiding this comment

SarveshLimaye commented Nov 4, 2021

lemeurherve commented Nov 4, 2021

SarveshLimaye commented Nov 4, 2021

lemeurherve commented Nov 4, 2021 • edited Loading

SarveshLimaye commented Nov 5, 2021

dduportal commented Nov 5, 2021

SarveshLimaye commented Nov 25, 2021

lemeurherve commented Dec 8, 2021

lemeurherve commented Dec 8, 2021

lemeurherve commented Dec 8, 2021

lemeurherve left a comment

Choose a reason for hiding this comment

lemeurherve Dec 8, 2021

Choose a reason for hiding this comment

SarveshLimaye commented Dec 8, 2021 • edited Loading

SarveshLimaye commented Dec 8, 2021 • edited Loading

dduportal commented Dec 22, 2021

dduportal commented Dec 22, 2021

SarveshLimaye commented Dec 22, 2021

dduportal commented Aug 4, 2022

lemeurherve commented Nov 4, 2021 •

edited

Loading

SarveshLimaye commented Dec 8, 2021 •

edited

Loading

SarveshLimaye commented Dec 8, 2021 •

edited

Loading