Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suspend distribution of the windows-slaves-plugin #4221

Closed
jtnord opened this issue Aug 9, 2024 · 2 comments · Fixed by jenkins-infra/update-center2#791
Closed

Suspend distribution of the windows-slaves-plugin #4221

jtnord opened this issue Aug 9, 2024 · 2 comments · Fixed by jenkins-infra/update-center2#791
Assignees

Comments

@jtnord
Copy link

jtnord commented Aug 9, 2024

Service(s)

Update center

Summary

The plugin has not worked for a few years with any version of Windows that is secure.

As such I am proposing that the repo is archived and the plugin is suspended from the Update Center.

Reproduction steps

No response

@jtnord jtnord added the triage Incoming issues that need review label Aug 9, 2024
@MarkEWaite
Copy link

MarkEWaite commented Aug 9, 2024

+1 from me. We should probably also suspend distribution of the one plugin that depends on it, the multi-slave config plugin. The multi-slave config plugin was last released 10 years ago, has been deprecated for over 2 years, and does not have an active maintainer.

Why I think that suspension is the right approach

We suspend distribution of plugins that depend on a service that no longer exists or is end of life like:

This feels like a similar case to services that are end of life. Windows is not end of life, but the services required for this plugin have been end of life since at least March 2023. The plugin was deprecated almost two years ago.

The plugin installation statistics show that there are still almost 80,000 installations of the plugin, but only 22% of those installations are on 2.426.3 or newer.

Users with the plugin already installed will not be affected by distribution being suspended. Users with configuration as code definitions that include the plugin will need to remove it from their configuration as code definition. They will receive an error message when they attempt to download the plugin version.

@MarkEWaite MarkEWaite self-assigned this Aug 9, 2024
@MarkEWaite MarkEWaite removed the triage Incoming issues that need review label Aug 9, 2024
MarkEWaite added a commit to MarkEWaite/update-center2 that referenced this issue Aug 9, 2024
We suspend distribution of plugins that depend on a service that no
longer exists or is end of life like:

* jenkins-infra#732
* jenkins-infra#708
* jenkins-infra#676
* jenkins-infra#587

This is a similar case to services that are end of life.  Windows is
not end of life, but the services required for this plugin have been end
of life since at least March 2023. The plugin was deprecated as noted in
https://github.com/jenkinsci/windows-slaves-plugin?tab=readme-ov-file#notice-of-deprecation
almost two years ago in November 2022.
jenkinsci/windows-slaves-plugin@cdafd13

The plugin installation statistics
https://stats.jenkins.io/pluginversions/windows-slaves.html show that
there are still almost 80,000 installations of the plugin, but only 22%
of those installations are on 2.426.3 or newer.  Most installations of
the plugin are not upgrading their Jenkins controller version.

Users with the plugin already installed will not be affected by
distribution being suspended.  Users with configuration as code
definitions that include the plugin will need to remove it from their
configuration as code definition.  They will receive an error message
when they attempt to download the plugin version.

Implied dependencies on the plugin were removed from Jenkins 2.386

* jenkinsci/jenkins#7568

The plugin was removed from the setup wizard in Jenkins 2.379

* jenkinsci/jenkins#7414

Fix jenkins-infra/helpdesk#4221
@MarkEWaite MarkEWaite added this to the infra-team-sync-2024-08-13 milestone Aug 9, 2024
@MarkEWaite MarkEWaite changed the title suspend distribution of the windows-slaves-plugin Suspend distribution of the windows-slaves-plugin Aug 9, 2024
daniel-beck pushed a commit to jenkins-infra/update-center2 that referenced this issue Aug 22, 2024
We suspend distribution of plugins that depend on a service that no
longer exists or is end of life like:

* #732
* #708
* #676
* #587

This is a similar case to services that are end of life.  Windows is
not end of life, but the services required for this plugin have been end
of life since at least March 2023. The plugin was deprecated as noted in
https://github.com/jenkinsci/windows-slaves-plugin?tab=readme-ov-file#notice-of-deprecation
almost two years ago in November 2022.
jenkinsci/windows-slaves-plugin@cdafd13

The plugin installation statistics
https://stats.jenkins.io/pluginversions/windows-slaves.html show that
there are still almost 80,000 installations of the plugin, but only 22%
of those installations are on 2.426.3 or newer.  Most installations of
the plugin are not upgrading their Jenkins controller version.

Users with the plugin already installed will not be affected by
distribution being suspended.  Users with configuration as code
definitions that include the plugin will need to remove it from their
configuration as code definition.  They will receive an error message
when they attempt to download the plugin version.

Implied dependencies on the plugin were removed from Jenkins 2.386

* jenkinsci/jenkins#7568

The plugin was removed from the setup wizard in Jenkins 2.379

* jenkinsci/jenkins#7414

Fix jenkins-infra/helpdesk#4221
@MarkEWaite
Copy link

MarkEWaite commented Aug 22, 2024

Distribution of the plugin has been suspended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants