feat(cik8s,doks): add dockerhub image pull secret for datadog and jenkins-agents #2112
Conversation
| @@ -13,7 +13,17 @@ repositories: | |||
| - name: jenkins-infra | |||
| url: https://jenkins-infra.github.io/helm-charts | |||
| releases: | |||
| - name: docker-registry-secrets | |||
| namespace: default | |||
There was a problem hiding this comment.
I wouldn't put it in the "default" namespace, maybe "docker-registry" here?
There was a problem hiding this comment.
agreed, but @dduportal said to go by step ;) ...
still a WIP
There was a problem hiding this comment.
We discovered that specifying a nemspace for the helmfile release is required (despite what the doc. says) to allow referencing from other release (with the needs keyword).
Since this helm chart does not create any resource in the aformentioned namespace (it creates in the value-specified namespaceS), I proposed to use "defaukt" here, as a "no-op" value.
Stephane just added a comment in the code to explain this. WDYT?
There was a problem hiding this comment.
I dunno about the "default" namespace, which is frequently used for tests or install without being cautious, and subject to deleting. Not a big problem per se, but I'd put it in the existing "jenkins-agents", WDYT?
|
I've merged to ensure that the credential is re-created in @lemeurherve if you feel like that the namespace |
as per jenkins-infra/helpdesk#2830
secret added in : https://github.com/jenkins-infra/charts-secrets/commit/f44237af5ee0ffb40e7998d7f0dc07e1d17246d6