Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(release): use Jenkins Infra inbound-agent Windows Docker image #2468

Merged
merged 1 commit into from
Jun 7, 2022
Merged

feat(release): use Jenkins Infra inbound-agent Windows Docker image #2468

merged 1 commit into from
Jun 7, 2022

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve requested review from dduportal and a team June 7, 2022 08:47
lemeurherve
lemeurherve commented Jun 7, 2022
View reviewed changes
config/ext_jenkins-release.yaml
Comment on lines -202 to -203
# Required to be jenkins/<helm-release>-jenkins-slave as defined here
# https://github.com/helm/charts/blob/ef0d749132ecfa61b2ea47ccacafeaf5cf1d3d77/stable/jenkins/templates/jenkins-master-networkpolicy.yaml#L27
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obsolete comment.

@dduportal dduportal merged commit 6eff97c into jenkins-infra:main Jun 7, 2022
lemeurherve added a commit that referenced this pull request Jun 7, 2022
@lemeurherve
fix: revert jenkinsUrl
4e6378b 
Revert the change introduced in #2468 which prevented agent to connect to the controller on release.ci.jenkins.io (cf https://release.ci.jenkins.io/job/core/job/weekly/job/release/job/master/135/console)
@lemeurherve lemeurherve mentioned this pull request Jun 7, 2022
Merged
dduportal pushed a commit that referenced this pull request Jun 7, 2022
@lemeurherve
fix: revert jenkinsUrl (#2473)
5e61ccf 
Revert the change introduced in #2468 which prevented agent to connect to the controller on release.ci.jenkins.io (cf https://release.ci.jenkins.io/job/core/job/weekly/job/release/job/master/135/console)
@dduportal dduportal mentioned this pull request Jun 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduportal dduportal dduportal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lemeurherve @dduportal @lemeurherveCB