This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Fix(update.jenkins.io) add hostname and templatize puppet #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smerle33
force-pushed
the
fix/hostname_puppet
branch
from
July 8, 2022 12:19
0ff7e21
to
62c6f7f
Compare
@dduportal not quite sure if you want more templatization within the cloudinit script. |
dduportal
reviewed
Jul 8, 2022
dduportal
reviewed
Jul 8, 2022
dduportal
reviewed
Jul 11, 2022
lemeurherve
reviewed
Jul 11, 2022
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
reviewed
Jul 11, 2022
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
approved these changes
Jul 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job ! Let's go go go for it !
Plan: 3 to add, 1 to change, 3 to destroy. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install puppet agent from cloudinit with correct hostname. Had to downgrade from ubuntu 22.04 to 20.04 for compliance.