Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(goss): correct invalid yaml #1147

Merged
merged 1 commit into from
May 13, 2024
Merged

chore(goss): correct invalid yaml #1147

merged 1 commit into from
May 13, 2024

Conversation

smerle33
Copy link
Contributor

@smerle33 smerle33 commented May 13, 2024 •
edited
Loading

as per jenkins-infra/helpdesk#4090

escape templating to get yaml compliant

@smerle33
Copy link
Contributor Author

updatecli worked as expected locally:

updateJDK21VersionInGoss
------------------------

**Dry Run enabled**

✔ - no change detected:
        * key "$.command.jdk21.stdout[0]" already set to "21.0.3+9", from file "goss/goss-linux.yaml"
        * key "$.command.jdk21.stdout[0]" already set to "21.0.3+9", from file "goss/goss-windows.yaml"

@smerle33 smerle33 marked this pull request as ready for review May 13, 2024 15:00
@smerle33 smerle33 requested a review from dduportal May 13, 2024 15:01
@smerle33 smerle33 changed the title chore(updatecli): change skip evaluation to scalar block chore(goss): change skip evaluation to scalar block to correct invalid yaml May 13, 2024
@smerle33 smerle33 changed the title chore(goss): change skip evaluation to scalar block to correct invalid yaml chore(goss): correct invalid yaml May 13, 2024
dduportal
dduportal approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per #1147 (comment), the updatecli check fails for now but will be fixed once merged.

LGTM

@dduportal dduportal merged commit ed6d9bb into jenkins-infra:main May 13, 2024
1 of 2 checks passed
@smerle33 smerle33 deleted the correct/goss/updatecli branch May 20, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduportal dduportal dduportal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smerle33 @dduportal