Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(updatecli/goss): change yaml engine to comply with goss templating on goss-windows and improve goss test #1170

Merged
merged 20 commits into from
May 23, 2024
Merged

chore(updatecli/goss): change yaml engine to comply with goss templating on goss-windows and improve goss test #1170

merged 20 commits into from
May 23, 2024

Conversation

smerle33
Copy link
Contributor

@smerle33 smerle33 commented May 16, 2024 •
edited
Loading

as per jenkins-infra/helpdesk#4090
the goss exception is failing with a scalar block and updatecli is failing if it's on a one line. To avoid updatecli failure, we need to use the alternate yaml engine yamlpath

@smerle33 smerle33 changed the title chore(goss): add environement variable to goss execution chore(updatecli/goss): change yaml engine to comply with goss templating on goss-windows May 16, 2024
@smerle33 smerle33 marked this pull request as ready for review May 16, 2024 07:07
@smerle33 smerle33 requested a review from dduportal May 16, 2024 07:07
@smerle33 smerle33 marked this pull request as draft May 16, 2024 08:38
@smerle33 smerle33 marked this pull request as ready for review May 17, 2024 13:04
@smerle33 smerle33 marked this pull request as draft May 17, 2024 15:30
@smerle33
Copy link
Contributor Author

even if it seems ok, it's not ...

[2024-05-17T14:18:59.052Z] �[0;32m2024-05-17T14:18:58Z:     azure-arm.windows: ......FF...................�[0m
[2024-05-17T14:18:59.052Z] �[1;31m2024-05-17T14:18:58Z: ==> azure-arm.windows: 2024-05-17T14:18:57Z [DEBUG][Command][visualstudio][stderr]  'C:\Program' is not recognized as an internal or external command,�[0m
[2024-05-17T14:18:59.052Z] �[0;32m2024-05-17T14:18:58Z:     azure-arm.windows:�[0m
[2024-05-17T14:18:59.052Z] �[1;31m2024-05-17T14:18:58Z: ==> azure-arm.windows: 2024-05-17T14:18:57Z [DEBUG][Command][visualstudio][stderr]  operable program or batch file.�[0m
[2024-05-17T14:18:59.052Z] �[1;31m2024-05-17T14:18:58Z: ==> azure-arm.windows: 2024-05-17T14:18:57Z [DEBUG][Command][visualstudio][stderr]�[0m
[2024-05-17T14:18:59.052Z] �[0;32m2024-05-17T14:18:58Z:     azure-arm.windows: Failures/Skipped:�[0m
[2024-05-17T14:18:59.052Z] �[0;32m2024-05-17T14:18:58Z:     azure-arm.windows:�[0m

@smerle33
Copy link
Contributor Author

working !
windows 2019: 2024-05-21T10:16:02Z: ==> azure-arm.windows: 2024-05-21T10:16:01Z [DEBUG][Command][visualstudio][stdout] 16.11.2.50704
windows 2022:

12:06:22  
2024-05-21T10:06:19Z:     azure-arm.windows: Command: visualstudio: exit-status: skipped

12:06:22  
2024-05-21T10:06:19Z:     azure-arm.windows: Command: visualstudio: stdout: skipped

@smerle33 smerle33 marked this pull request as ready for review May 21, 2024 11:59
@smerle33 smerle33 changed the title chore(updatecli/goss): change yaml engine to comply with goss templating on goss-windows chore(updatecli/goss): change yaml engine to comply with goss templating on goss-windows and improve goss test May 21, 2024
dduportal
dduportal reviewed May 23, 2024
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind expanding the 3 comments (to explain the "why") or removing them? In their current state they are not indicating anything for the reader

smerle33 and others added 2 commits May 23, 2024 09:43
@smerle33 @dduportal
Apply suggestions from code review
90af850 
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
@smerle33
Merge branch 'main' into goss/environement
b1a4b73
dduportal
dduportal approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dduportal dduportal merged commit 24740d1 into jenkins-infra:main May 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduportal dduportal dduportal approved these changes

Assignees
No one assigned
Labels
chore goss updatecli windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smerle33 @dduportal