feat(ubuntu):Add an amazon-ebs AMI builder

[jayfranco999]

As per jenkins-infra/helpdesk#4353 (comment)

Related to jenkins-infra/helpdesk#4316 (comment)

This PR introduces the following to packer-images:

• Add amazon-ebs builder logic in Jenkinsfile_k8s
• Include EC2 source for build-jenkins-agent-ubuntu.pkr.hcl
• Add datasources.pkr.hcl to look-up ubuntu-22_04 AMI id for respective architecture
• Define aws_instance_types in locals.pkr.hcl
• Include Amazon plugin for packer-images
• Define all the common settings for AWS base image AMI's in sources.pkr.hcl
• Add AWS related packer-image variables (AWS region and credentials)

[dduportal]

• Updatecli check fails: as the manifest assumes the code is on the principal branch, either you add it on a subsequent PR or we can accept it's working once merged (but you'll have to test it locally without the scmid: keys)
• We must use environment variable for the AWS provider setup. Please read carefully https://developer.hashicorp.com/packer/integrations/hashicorp/amazon#environment-variables and https://developer.hashicorp.com/packer/integrations/hashicorp/amazon#static-credentials and mùake sure you get the difference (see suggestions): it's a blocker

[jayfranco999]

Update:

ubuntu-22_04 AMD64 and ARM64 AMI images were successfully built with packer-images – https://infra.ci.jenkins.io/job/infra-tools/job/packer-images/job/PR-1447/5/

Since windows AMI image source logic is not included in this PR, the windows agent builds are failing in PACKER_LOG=1 packer validate ./ stage of the build pipeline with exit-code-1

[2024-10-15T12:27:00.527Z]   on sources.pkr.hcl line 33:
[2024-10-15T12:27:00.527Z]   (source code not available)
[2024-10-15T12:27:00.527Z] 
[2024-10-15T12:27:00.527Z] with data.amazon-ami as map of object with 1 element,
[2024-10-15T12:27:00.527Z]      local.agent_os_version_safe as "2022",
[2024-10-15T12:27:00.527Z]      var.agent_os_type as "windows".
[2024-10-15T12:27:00.527Z] 
[2024-10-15T12:27:00.527Z] The given key does not identify an element in this collection value.
[2024-10-15T12:27:00.527Z] 
[2024-10-15T12:27:00.527Z] Error: Invalid index
[2024-10-15T12:27:00.527Z] 
[2024-10-15T12:27:00.527Z]   on sources.pkr.hcl line 33:
[2024-10-15T12:27:00.527Z]   (source code not available)
[2024-10-15T12:27:00.527Z] 
[2024-10-15T12:27:00.527Z] with data.amazon-ami as map of object with 1 element,
[2024-10-15T12:27:00.527Z]      local.agent_os_version_safe as "2022",
[2024-10-15T12:27:00.527Z]      var.agent_os_type as "windows".
[2024-10-15T12:27:00.527Z] 
[2024-10-15T12:27:00.527Z] The given key does not identify an element in this collection value.

I believe the problem is with source_ami = data.amazon-ami["${var.agent_os_type}-${local.agent_os_version_safe}"].id command in sources.pkr.hcl that causes errors in the packer validate stage.

Further steps will include exporting the aws credentials and region for terraform-packer-user as environment variables instead of using static variables.

[dduportal]

@jayfranco999 Proposal for a clear title:

feat(ubuntu):Add an `amazon-ebs` AMI builder

instead of:

feat!(aws):Add Amazon-ebs builder for Linux AMIs

• It is a new feature, not a breaking change at all
• AWS is not a component of the repository. Ubuntu is.

WDYT?

Addressed with latest commit