Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(updatecli):Track docker image digests for ubuntu 22_04 AMD64 and ubuntu 22_04 ARM64 #1508

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

jayfranco999
Copy link
Collaborator

As per jenkins-infra/helpdesk#4365 (comment)

This PR pins and track docker image digests for ubuntu 22_04 AMD64 and ubuntu 22_04 ARM64

…d ARM64

Signed-off-by: jayfranco999 <jaideepfrancis999@gmail.com>
Signed-off-by: jayfranco999 <jaideepfrancis999@gmail.com>
@jayfranco999 jayfranco999 marked this pull request as draft November 12, 2024 08:34
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, the updatecli manifests are good. As per my local tests (with scmid commented:

* key "$.docker.ubuntu.'22.04'.amd64" already set to "sha256:3d1556a8a18cf5307b121e0a98e93f1ddf1f3f8e092f1fddfd941254785b95d7", from file "./images-versions.yaml"
# ...
* key "$.docker.ubuntu.'22.04'.arm64" already set to "sha256:7c75ab2b0567edbb9d4834a2c51e462ebd709740d1f2c40bcd23c56e974fe2a8", from file "./images-versions.yaml"

There is a bit more of work to do:

  • Blocker: The HCL change need to be fixed (please try it locally before pushing code which builds for 1 h).

sources.pkr.hcl Outdated Show resolved Hide resolved
Signed-off-by: jayfranco999 <jaideepfrancis999@gmail.com>
@jayfranco999
Copy link
Collaborator Author

Tested locally and successfully:

2024-11-12T19:17:22+05:30: Build 'docker.ubuntu' finished after 22 minutes 48 seconds.

==> Wait completed after 22 minutes 48 seconds
==> Builds finished. The artifacts of successful builds are:
==> Wait completed after 22 minutes 48 seconds

Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Manifests are working as expected on a local check.

@jayfranco999 jayfranco999 marked this pull request as ready for review November 13, 2024 09:00
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks are failings for unrelated reasons:

  • Packer fails due to an AWS AMI export error (transient)
  • Updatecli because we introduce target changes as part of the PR: needs to be on principal branch (after merging) to work

@dduportal dduportal merged commit 9697076 into jenkins-infra:main Nov 13, 2024
0 of 2 checks passed
jayfranco999 added a commit to jayfranco999/packer-images that referenced this pull request Nov 26, 2024
…and `ubuntu 22_04 ARM64` (jenkins-infra#1508)

* chore(updatecli):Track docker image digests for ubuntu 22_04 AMD64 and ARM64

Signed-off-by: jayfranco999 <jaideepfrancis999@gmail.com>

* fixup

Signed-off-by: jayfranco999 <jaideepfrancis999@gmail.com>

* fixup

Signed-off-by: jayfranco999 <jaideepfrancis999@gmail.com>

---------

Signed-off-by: jayfranco999 <jaideepfrancis999@gmail.com>
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants