-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(windows) add AWS EC2 builds (2019 and 2022) #1611
Merged
dduportal
merged 9 commits into
jenkins-infra:main
from
dduportal:feat/ec2/add-win-builds
Dec 20, 2024
Merged
feat(windows) add AWS EC2 builds (2019 and 2022) #1611
dduportal
merged 9 commits into
jenkins-infra:main
from
dduportal:feat/ec2/add-win-builds
Dec 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduportal
changed the title
Feat/ec2/add win builds
feat(windows) add AWS EC2 builds (2019 and 2022)
Dec 18, 2024
Build 4 did fail with:
|
dduportal
added a commit
to jenkins-infra/azure
that referenced
this pull request
Dec 18, 2024
Related to jenkins-infra/packer-images#1611 (comment) This PR allows WinRM outbound to *any* internet IP, as we can't determine in advance the public IPs of packer images in EC2.
dduportal
added a commit
to dduportal/packer-images
that referenced
this pull request
Dec 18, 2024
Note: partial revert of jenkins-infra#734 Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
force-pushed
the
feat/ec2/add-win-builds
branch
from
December 18, 2024 19:26
9e45534
to
fd6ccc4
Compare
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Note: partial revert of jenkins-infra#734 Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
…datecli manifests. Signed-off-by: Damien Duportal <damien.duportal@gmail.com> fixup Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
…ses and prelaunch hadolint to avoid timeouts - Note about `goss`: default for MaxConcurrent seems to be 50 - https://github.com/goss-org/goss/blob/00e9355293bbe8b554f8b874cced6a55aa92ffd4/util/config.go\#L79 Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
force-pushed
the
feat/ec2/add-win-builds
branch
from
December 19, 2024 18:40
c5a99f1
to
80a8b89
Compare
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. jenkins-infra/helpdesk#4354
This PRs (re)introduces the Windows (2019 and 2022) builds for AWS EC2.
updatecli
manifest to track them. Will most probably move to another PR, but here for now (failing the Updatecli check)amazon-ebs
'ssource_ami
attribute to the source (instead of duplicating per builder). It's a test (now that thetry()
protects us, but might need to be reverted.install-packer.sh
scriptlocal.windows_disk_size_gb
tolocal.disk_size_gb
- downstream PR: chore(updatecli) fix packer image disk size tracking jenkins-infra#3788goss
on windows to ensure successhadolint
CLI on Linux to avoid frequent timeouts due to concurency issues