Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(windows) add AWS EC2 builds (2019 and 2022) #1611

Merged
merged 9 commits into from
Dec 20, 2024

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Dec 18, 2024

Ref. jenkins-infra/helpdesk#4354

This PRs (re)introduces the Windows (2019 and 2022) builds for AWS EC2.

  • Set up Windows AMI in the YAML descriptor in which we track them
    • Added updatecli manifest to track them. Will most probably move to another PR, but here for now (failing the Updatecli check)
  • Partial revert of Cleanup: remove Amazon builder #734 (only what we need: source, build block and the sysprep "last" provisionner)
  • Add back the Windows AWS EC2 build (and simplify Jenkinsfile matrix)
  • Wip: factorize the amazon-ebs 's source_ami attribute to the source (instead of duplicating per builder). It's a test (now that the try() protects us, but might need to be reverted.
  • feat: Set up (all!) AWS sources to use enforced IMDS v2 (instead of legacy) to avoid lateral attacks
  • cleanup: remove unused install-packer.sh script
  • Nit: Renamed local.windows_disk_size_gb to local.disk_size_gb - downstream PR: chore(updatecli) fix packer image disk size tracking jenkins-infra#3788
  • fix(test): fine tune goss on windows to ensure success
    • only check for hadolint CLI on Linux to avoid frequent timeouts due to concurency issues
    • Decrease goss concurency

@dduportal dduportal changed the title Feat/ec2/add win builds feat(windows) add AWS EC2 builds (2019 and 2022) Dec 18, 2024
@dduportal
Copy link
Contributor Author

Build 4 did fail with:

  • Windows AWS (amazon-ebs) builds are failing with a Timeout waiting for WinRM (after retrieving the password successfully from the console)
    • Port is open in the inbound security group, but I guess it is not on the infra.ci agent outbound section.
  • Azure builds are all failing (Ubuntu and Windows) with:
 ==> azure-arm.ubuntu: ERROR:   -> InvalidParameter : Resource '<REDACTED>' has invalid parameters. Details: The value of parameter imageReference.version is invalid.
unexpected status 400 (400 Bad Request) with error: InvalidTemplateDeployment: The template deployment '<REDACTED>' is not valid according to the validation procedure.
  • Docker (Linux) are successful though

dduportal added a commit to jenkins-infra/azure that referenced this pull request Dec 18, 2024
Related to
jenkins-infra/packer-images#1611 (comment)

This PR allows WinRM outbound to *any* internet IP, as we can't
determine in advance the public IPs of packer images in EC2.
dduportal added a commit to dduportal/packer-images that referenced this pull request Dec 18, 2024
Note: partial revert of jenkins-infra#734

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal dduportal force-pushed the feat/ec2/add-win-builds branch from 9e45534 to fd6ccc4 Compare December 18, 2024 19:26
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Note: partial revert of jenkins-infra#734

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
…datecli manifests.

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>

fixup

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
…ses and prelaunch hadolint to avoid timeouts

- Note about `goss`: default for MaxConcurrent seems to be 50 - https://github.com/goss-org/goss/blob/00e9355293bbe8b554f8b874cced6a55aa92ffd4/util/config.go\#L79

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal dduportal force-pushed the feat/ec2/add-win-builds branch from c5a99f1 to 80a8b89 Compare December 19, 2024 18:40
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal dduportal added enhancement New feature or request windows aws labels Dec 20, 2024
@dduportal dduportal marked this pull request as ready for review December 20, 2024 11:12
@dduportal dduportal merged commit 7f37b7f into jenkins-infra:main Dec 20, 2024
2 checks passed
@dduportal dduportal deleted the feat/ec2/add-win-builds branch December 20, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws enhancement New feature or request windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant