Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(locale): add the local setup within packer #345

Merged
merged 4 commits into from
Sep 29, 2022
Merged

chore(locale): add the local setup within packer #345

merged 4 commits into from
Sep 29, 2022

Conversation

smerle33
Copy link
Contributor

@smerle33 smerle33 commented Sep 16, 2022 •
edited
Loading

as per #343
permanent correction for locale with a packer variable

@smerle33 smerle33 marked this pull request as ready for review September 16, 2022 15:58
dduportal
dduportal requested changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment •
edited by smerle33
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retaining until @smerle33 implements a "check agent availabity" for locale on linux agents.

@smerle33
Copy link
Contributor Author

Retaining until @smerle33 implements a "check agent availabity" for locale on linux agents.

as per jenkins-infra/acceptance-tests#32
this should be resolved

@smerle33 smerle33 requested a review from dduportal September 28, 2022 09:23
@smerle33 smerle33 merged commit 12643f0 into jenkins-infra:main Sep 29, 2022
@dduportal dduportal changed the title feat(locale): add the local setup within packer chore(locale): add the local setup within packer Sep 29, 2022
@smerle33 smerle33 deleted the PR_Review1110274614 branch May 22, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduportal dduportal dduportal approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smerle33 @dduportal @smerleCB