Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(windows) Use goss for sanity checks for JDKs and trivy #818

Merged

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Sep 24, 2023

Related to jenkins-infra/helpdesk#3763

This PR introduces the following changes:

  • Install goss on the Windows templates
  • Introduces a goss/goss-windows.yaml test harness only for Windows which is deleted at the end (cc @smerle33 for info, we'll want to remove linux and common test harness when we will refactor)
  • Add a "breakpoint" provisionner on Windows to allow local debug
  • Move the sanity checks for all the JDK, trivy and default JDK

💡 Note: this PR does NOT add an updatecli manifest. We'll wait for the aforementioned refactor

@dduportal dduportal force-pushed the chore/tests/use-goss-on-windows branch from 87188c6 to b3da3b1 Compare September 26, 2023 14:55
@dduportal dduportal changed the title Chore/tests/use goss on windows tests(windows) Use goss for sanity checks for JDK and trivy Sep 26, 2023
@dduportal dduportal marked this pull request as ready for review September 26, 2023 17:11
@dduportal dduportal marked this pull request as draft October 19, 2023 17:59
@dduportal dduportal force-pushed the chore/tests/use-goss-on-windows branch 2 times, most recently from 2d580fa to a22d612 Compare October 20, 2023 07:26
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal dduportal force-pushed the chore/tests/use-goss-on-windows branch from 02be37e to 874469c Compare October 21, 2023 14:53
@dduportal dduportal changed the title tests(windows) Use goss for sanity checks for JDK and trivy tests(windows) Use goss for sanity checks for JDKs and trivy Oct 21, 2023
@dduportal dduportal marked this pull request as ready for review October 21, 2023 16:13
@dduportal
Copy link
Contributor Author

Ready to review and merge (checks are 👍 )

@dduportal
Copy link
Contributor Author

Self Merging as an excuse to trigger 1.36.1 version

@dduportal dduportal merged commit 2d008ae into jenkins-infra:main Oct 24, 2023
@dduportal dduportal deleted the chore/tests/use-goss-on-windows branch October 24, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant