chore(updatecli): track the official jdk21 version instead of earlyavailable #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduportal
approved these changes
Oct 17, 2023
| # JDK version (21+35) | ||
| ## https://github.com/adoptium/temurin21-binaries/releases/download/jdk-21%2B35/OpenJDK21U-jdk_aarch64_linux_hotspot_21_35.tar.gz | ||
| urlEncodedJDKVersion="${jdk_version//+/%2B}" | ||
| echo "https://github.com/adoptium/temurin21-binaries/releases/download/jdk-${urlEncodedJDKVersion}/OpenJDK21U-jdk_${platform}_hotspot_${jdk_version//+/_}" |
There was a problem hiding this comment.
The JDK version is already URL-encoded line 15.
Suggested change
| echo "https://github.com/adoptium/temurin21-binaries/releases/download/jdk-${urlEncodedJDKVersion}/OpenJDK21U-jdk_${platform}_hotspot_${jdk_version//+/_}" | |
| echo "https://github.com/adoptium/temurin21-binaries/releases/download/jdk-${jdk_version_urlencoded}/OpenJDK21U-jdk_${platform}_hotspot_${jdk_version_urlencoded//+/_}" |
Comment on lines
+36
to
+37
| # JDK version (21+35) | ||
| ## https://github.com/adoptium/temurin21-binaries/releases/download/jdk-21%2B35/OpenJDK21U-jdk_aarch64_linux_hotspot_21_35.tar.gz |
There was a problem hiding this comment.
Suggested change
| # JDK version (21+35) | |
| ## https://github.com/adoptium/temurin21-binaries/releases/download/jdk-21%2B35/OpenJDK21U-jdk_aarch64_linux_hotspot_21_35.tar.gz | |
| ## JDK21 URLs have an underscore ('_') instead of a plus ('+') in their archive names |
Let's stay homogeneous with the other JDKs
dduportal
added
enhancement
dduportal
added a commit
to dduportal/packer-images
that referenced
this pull request
Oct 19, 2023
fixup of jenkins-infra#839 Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
added a commit
to dduportal/packer-images
that referenced
this pull request
Oct 19, 2023
fixup of jenkins-infra#839 Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
added a commit
that referenced
this pull request
Oct 19, 2023
* fix: Use Temurin JDK21 stable URLs fixup of #839 Signed-off-by: Damien Duportal <damien.duportal@gmail.com> * feat: bump JDK21 to 21+35 GA stable Signed-off-by: Damien Duportal <damien.duportal@gmail.com> --------- Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per jenkins-infra/helpdesk#3783