chore(updatecli): update updatecli manifests to use the new goss-common.yaml file #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
lemeurherve
approved these changes
Jan 15, 2024
| @@ -174,7 +174,7 @@ $downloads = [ordered]@{ | |||
| 'cleanupLocal' = 'true'; | |||
| }; | |||
| 'jq' = @{ | |||
| 'url' = 'https://github.com/stedolan/jq/releases/download/jq-{0}/jq-win64.exe' -f $env:JQ_VERSION; | |||
| 'url' = 'https://github.com/jqlang/jq/releases/download/jq-{0}/jq-win64.exe' -f $env:JQ_VERSION; | |||
There was a problem hiding this comment.
I would add something about this change in the PR body.
Was it required for this PR or could it have been its own?
There was a problem hiding this comment.
it's to be compliant with this change updatecli/updatecli.d/jq.yml on the same PR, the new name is jqlang and seems better to use than the oldone stedolan that is forwarded to jqlang
There was a problem hiding this comment.
Thanks for the explanation. I still would add a mention of this change in the PR body 😉
lemeurherve
approved these changes
Jan 15, 2024
| @@ -174,7 +174,7 @@ $downloads = [ordered]@{ | |||
| 'cleanupLocal' = 'true'; | |||
| }; | |||
| 'jq' = @{ | |||
| 'url' = 'https://github.com/stedolan/jq/releases/download/jq-{0}/jq-win64.exe' -f $env:JQ_VERSION; | |||
| 'url' = 'https://github.com/jqlang/jq/releases/download/jq-{0}/jq-win64.exe' -f $env:JQ_VERSION; | |||
There was a problem hiding this comment.
Thanks for the explanation. I still would add a mention of this change in the PR body 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up #988 to update updatecli
as per jenkins-infra/helpdesk#3763