Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA-2435] Remove repo.azure mirrors #135

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Conversation

olblak
Copy link
Member

@olblak olblak commented Jan 27, 2020

repo.azure.jenkins.io is deprecated and we are reverting it to repo.jenkins-ci.org
More information here

@olblak olblak requested a review from a team January 27, 2020 13:26
Copy link
Contributor

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to get some metrics which justify the statements in INFRA-2435? I would like to discuss it before we proceed

@olblak
Copy link
Member Author

olblak commented Jan 27, 2020

I made some tests from ci.jenkins.io, where the bottom terminal is repo.azure.jenkins-ci.org
If you want to take more time to discuss about it, then keep in mind that the cluster will be gone in two days.

So either we change every occurrence of repo.azure.jenkins.io to repo.jenkins-ci.org or we redeploy repo.azure.jenkins.io on the new kubernetes cluster.

image

@oleg-nenashev
Copy link
Contributor

I am fine with that as a last resort, but we may need to find a solution quickly after Jan 31

@olblak
Copy link
Member Author

olblak commented Jan 30, 2020

I am merging this to see how it behaves

@olblak olblak merged commit 1a9f1d7 into jenkins-infra:master Jan 30, 2020
@jglick
Copy link
Contributor

jglick commented Feb 13, 2020

This PR does not make sense to me. The only real purpose for settings-azure.xml is to define this mirror. If we are getting rid of the mirror, we should delete the whole file, and the usages of it.

@jglick
Copy link
Contributor

jglick commented Feb 13, 2020

(All Jenkins POMs already define the Artifactory repository locations, so you do not need a special settings file for this; the Incrementals repository is already activated conditionally in a profile, so it is less than worthless to define it here; and the log level trick is already done by mvn command lines, and anyway obsolete as of Maven 3.6.1’s -ntp.)

@oleg-nenashev
Copy link
Contributor

This PR does not make sense to me. ... If we are getting rid of the mirror, we should delete the whole file, and the usages of it.

I believe the approach is right. If we ever restore the mirror or introduce other shared profiles for ci.jenkins.io, this file will be useful. So +100 for keeping the stub and requiring using it in ci.jenkins.io runs. Also, usage cleanup requires time which could be better spent elsewhere

@jglick
Copy link
Contributor

jglick commented Feb 13, 2020

If we ever restore the mirror or introduce other shared profiles for ci.jenkins.io, this file will be useful.

Perhaps, but then we should delete all sections from it and replace its body with

<!-- Stub in case we ever wish to reintroduce mirrors (see INFRA-2435) -->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants