Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow publishing reports on infra.ci #348

Merged
merged 3 commits into from
Apr 27, 2022
Merged

feat: allow publishing reports on infra.ci #348

merged 3 commits into from
Apr 27, 2022

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Apr 5, 2022

This PR is related to jenkins-infra/infra-reports#37.

It allows the method publishReport() to be executed from infra.ci and it relies on the az CLI that should already be installed on the agent template.

vars/publishReports.groovy Outdated Show resolved Hide resolved
@basil
Copy link
Contributor

basil commented Apr 20, 2022

My apologies in advance for what must be a particularly harsh merge conflict. Let me know if you want me to resolve it for you.

@dduportal
Copy link
Contributor Author

My apologies in advance for what must be a particularly harsh merge conflict. Let me know if you want me to resolve it for you.

Many thanks for the notifications and the work! No worries we'll handle this: that would be a great practical exercise with git conflicts.

@dduportal dduportal marked this pull request as ready for review April 20, 2022 08:42
@dduportal dduportal requested a review from a team April 20, 2022 08:42
@dduportal dduportal marked this pull request as draft April 20, 2022 08:42
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal dduportal requested review from timja and daniel-beck April 27, 2022 14:33
@dduportal dduportal changed the title Feat/allow publish reports infra.ci feat: allow publishing reports on infra.ci Apr 27, 2022
@dduportal dduportal marked this pull request as ready for review April 27, 2022 14:34
@dduportal
Copy link
Contributor Author

timja
timja previously approved these changes Apr 27, 2022
vars/publishReports.groovy Outdated Show resolved Hide resolved
Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
@dduportal dduportal enabled auto-merge (squash) April 27, 2022 15:55
@dduportal
Copy link
Contributor Author

Post note: merging this PR caused the problem jenkins-infra/repository-permissions-updater#2520.

@dduportal
Copy link
Contributor Author

Post note: same problem on jenkins-infra/core-taglibs-report-generator#11

lemeurherve pushed a commit to lemeurherve/pipeline-library that referenced this pull request Jun 1, 2022
* feat(publishReports) allow execution from infra.ci

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>

* fix(publishReports) avoid sh interpolations

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>

* Update vars/publishReports.groovy

Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>

Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
smerle33 pushed a commit to smerle33/pipeline-library that referenced this pull request Jan 16, 2024
* feat(publishReports) allow execution from infra.ci

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>

* fix(publishReports) avoid sh interpolations

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>

* Update vars/publishReports.groovy

Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>

Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants