feat(buildPlugin): switch artifact caching proxy to opt-out #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemeurherve
commented
Feb 1, 2023
| @@ -338,11 +338,27 @@ class BuildPluginStepTests extends BaseTest { | |||
| } | |||
|
|
|||
| @Test | |||
| void test_buildPlugin_with_artifact_caching_proxy_enabled_and_empty_provider_specified() throws Exception { | |||
| void test_buildPlugin_with_artifact_caching_proxy_disabled() throws Exception { | |||
There was a problem hiding this comment.
Additional case to test when useArtifactCachingProxy is set to false
dduportal
added a commit
to jenkinsci/jenkins-infra-test-plugin
that referenced
this pull request
Feb 2, 2023
|
End to end test of this PR: jenkinsci/jenkins-infra-test-plugin#63 as a safety net. (edit) success \o/ Ready to go! |
dduportal
approved these changes
Feb 2, 2023
lemeurherve
deleted the
helpdesk2752-switch-artifact-caching-proxy-to-opt-out
branch
smerle33
pushed a commit
to smerle33/pipeline-library
that referenced
this pull request
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this PR will be merged, every plugin using
buildPluginwill use one of the artifact caching proxy providers instead of repo.jenkins-ci.org and Maven Central to download its Maven artifacts.Successfully tested in jenkinsci/jenkins-infra-test-plugin#62
Close jenkins-infra/helpdesk#2752
Ref: jenkins-infra/helpdesk#3369