buildPlugin(): Allow passing Java level as a configuration argument #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivergondza
approved these changes
Dec 3, 2018
alecharp
approved these changes
Dec 5, 2018
|
Just added #80 in complement FYI. |
This was referenced Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing configuration support patches from @olivergondza in #76 , I tried to run the test automation against a plugin which still targets Java 7: jenkinsci/label-verifier-plugin#4 . It failed, because the new Jenkins core version uses Bytecode Compatibility Transformer which is no longer compatible with Java 7.
Other static checkers may fail in various way as well. In order to prevent it, I propose to add an escape hatch to the library so that a custom
java.levelcan be passed alongside a custom Jenkins version.