Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(infra) cleanup remnants of AWS and DO ACPs #866

Merged
merged 3 commits into from
Jun 12, 2024
Merged

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Jun 11, 2024

Related to jenkins-infra/helpdesk#3954

This PR is a minor cleanup of the ACP logic, following #858 and #859

As the AWS and DO cluster (and their respective ACPs) had been removed, let's remove the (unused) references

@dduportal dduportal requested a review from a team June 11, 2024 06:11
Copy link
Member

@lemeurherve lemeurherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty to update the corresponding tests that were failing, hope you don't mind 🙂

@dduportal
Copy link
Contributor Author

I took the liberty to update the corresponding tests that were failing, hope you don't mind 🙂

I don't mind at all, it make sense. Thanks!

@dduportal dduportal merged commit 3f8f639 into master Jun 12, 2024
3 checks passed
@dduportal dduportal deleted the dduportal-patch-1 branch June 12, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants