Use ID as fallback for developer name

jenkins-infra · Apr 9, 2022 · 1b6c01f · 1b6c01f
1 parent 736999e
commit 1b6c01f
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/plugins/gatsby-source-jenkinsplugins/utils.js b/plugins/gatsby-source-jenkinsplugins/utils.js
@@ -123,7 +123,7 @@ const processPlugin = ({createNode, names, stats, updateData, detachedPlugins, c
         names.push(pluginName);
         const developers = plugin.developers || [];
         const labels = plugin.labels || [];
-        developers.forEach(maint => {maint.id = maint.developerId, delete (maint.developerId);});
+        developers.forEach(convertDeveloper);
         plugin.scm = fixGitHubUrl(plugin.scm, plugin.defaultBranch || 'master');
         const pluginStats = stats[pluginName] || {installations: null};
         pluginStats.trend = computeTrend(plugin, stats, updateData.plugins);
@@ -271,6 +271,13 @@ const fixGitHubUrl = (url, defaultBranch) => {
     return url;
 };
 
+const convertDeveloper = (maint) => {
+    maint.id = maint.developerId;
+    // graceful degradation: if names are lost, use ID
+    maint.name = maint.name || maint.id.replace('_', ' ');
+    delete (maint.developerId);
+};
+
 const computeTrend = (plugin, stats, plugins) => {
     if (!stats[plugin.name]) {
         return 0;