Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ID as fallback for developer name #1150

Merged
merged 1 commit into from
Apr 9, 2022
Merged

Use ID as fallback for developer name #1150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion plugins/gatsby-source-jenkinsplugins/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ const processPlugin = ({createNode, names, stats, updateData, detachedPlugins, c
names.push(pluginName);
const developers = plugin.developers || [];
const labels = plugin.labels || [];
developers.forEach(maint => {maint.id = maint.developerId, delete (maint.developerId);});
developers.forEach(convertDeveloper);
plugin.scm = fixGitHubUrl(plugin.scm, plugin.defaultBranch || 'master');
const pluginStats = stats[pluginName] || {installations: null};
pluginStats.trend = computeTrend(plugin, stats, updateData.plugins);
Expand Down Expand Up @@ -271,6 +271,13 @@ const fixGitHubUrl = (url, defaultBranch) => {
return url;
};

const convertDeveloper = (maint) => {
maint.id = maint.developerId;
// graceful degradation: if names are lost, use ID
maint.name = maint.name || maint.id.replace('_', ' ');
delete (maint.developerId);
};

const computeTrend = (plugin, stats, plugins) => {
if (!stats[plugin.name]) {
return 0;
Expand Down