Ignore missing URL #1244
Merged
Ignore missing URL #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halkeye
reviewed
Oct 17, 2022
| @@ -75,7 +75,7 @@ const getPluginContent = async ({wiki, pluginName, reporter, createNode, createC | |||
| id: `${pluginName} <<< JenkinsPluginWiki`, | |||
| name: pluginName, | |||
| url: url, | |||
| baseHref: `${path.dirname(url)}/`, | |||
| baseHref: `${url && path.dirname(url)}/`, | |||
There was a problem hiding this comment.
won't this output false/?
path.dirname(url || '') would work maybe?
Honestly if there's no url, then there probalby isn't need to generate a wiki object.
There was a problem hiding this comment.
there probalby isn't need to generate a wiki object
yep, then the error message can be created in UI and we don't need to download it from API. I tried that in a new commit.
There was a problem hiding this comment.
I'm going to revert this line, there's no need for it, and it could result in a random false.
halkeye
reviewed
Oct 17, 2022
| @@ -181,21 +184,19 @@ function PluginPage({data: {jenkinsPlugin: plugin, reverseDependencies: reverseD | |||
| <h5>Maintainers</h5> | |||
| <PluginDevelopers developers={plugin.developers} /> | |||
| </div> | |||
| {shouldShowWikiUrl(plugin.wiki) && | |||
| {shouldShowWikiUrl(plugin.wiki || {}) && | |||
There was a problem hiding this comment.
I'm going to change it so shouldShowWikiUrl takes in a string, and then we can do plugin?.wiki?.url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.