Moved the plugin name above all the tabs and made it common for all tabs #363
Conversation
src/templates/plugin.jsx
Outdated
| @@ -60,10 +63,12 @@ function PluginPage({data: {jenkinsPlugin: plugin}}) { | |||
| </ul> | |||
| <div className="padded"> | |||
| {state.selectedTab === 'documentation' && (<> | |||
| <h1 className="title"> | |||
| {cleanTitle(plugin.title)} | |||
| <h1 className="title-details"> | |||
There was a problem hiding this comment.
There should only be one h1 on the page, this section doesn’t appear to need to be a heading at all.
Can you add a screenshot of a plugin with active security warnings too?
There was a problem hiding this comment.
Changing h1 into something more suitable would also help remove all this clutter from the heading in Google search results
https://www.google.com/search?q=jenkins+git+plugin&oq=jenkins+git+plugin
There was a problem hiding this comment.
Hi @timja, I tried to find some plugin with a security warning but didn't succeed. Can you help me out with some plugin names that have some security warning?
There was a problem hiding this comment.
@sachinmukherjee please check this one: https://plugins.jenkins.io/custom-job-icon/
There was a problem hiding this comment.
@zbynek I tried the custom job icon plugin but it is not showing any security warning in my development env.
There was a problem hiding this comment.
After following the above steps security warning is still not coming up
There was a problem hiding this comment.
@timja the screenshot of a plugin with a warning is above -- do you think it's OK for the scope of this PR or should something be done here? Personally I think it's weird that current warnings are hidden (you need to click the triangle) and warnings for old versions are shown directly. It might make sense to kill the triangle entirely and show the current warning as an alert similar to the adoption message. Maybe out of scope here?
There was a problem hiding this comment.
the above looks ok I think, (in comparison to the previous)
yes it's very weird and needs a re-design
There was a problem hiding this comment.
Can I commit my files with the above mentioned changes?
timja
changed the title
Related to issue #306
Summary of this pull request: Moved the plugin name above all tabs and made it common for all tabs and also made version in a separate row.
@oleg-nenashev Please review this PR