Replace react-time-ago with react-timeago #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbynek
commented
Oct 7, 2020
| node: PropTypes.shape({ | ||
| id: PropTypes.string.isRequired, | ||
| title: PropTypes.string.isRequired, | ||
| reverseDependencies: PropTypes.shape({ |
There was a problem hiding this comment.
This was causing some console errors and didn't seem worth an own PR.
timja
approved these changes
Oct 7, 2020
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since react-time-ago package can't be updated to latest version without changes + it seems to be responsible for some console errors in development mode, why not replace it with
react-timeago which seems 10x more popular and brings in fewer transitive dependencies. There is also timeago-react, but I picked the package with more downloads.
CC @halkeye