Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using react-paginate so we dont need to manage that code ourselves #588

Merged
merged 2 commits into from
Feb 25, 2021
Merged

Switch to using react-paginate so we dont need to manage that code ourselves #588

merged 2 commits into from
Feb 25, 2021

Conversation

halkeye
Copy link
Member

@halkeye halkeye commented Feb 25, 2021

Related to issue # 586

Summary of this pull request:

@halkeye halkeye requested a review from a team as a code owner February 25, 2021 18:31
@halkeye halkeye mentioned this pull request Feb 25, 2021
Closed
MarkEWaite
MarkEWaite approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like the switch to react paginate so that someone else can do the computation of page components.

@halkeye halkeye merged commit ec68f7c into jenkins-infra:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markjacksonfishing markjacksonfishing markjacksonfishing approved these changes

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@halkeye @MarkEWaite @markjacksonfishing